Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a CloudFormation parameter allowing stack shutdown. #2022

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jpd236
Copy link
Contributor

@jpd236 jpd236 commented Feb 2, 2024

If this parameter is false (to turn off serving), we only keep around static entities - e.g. roles, instance functions, and the S3 bucket for image uploads. This allows us to more easily flip serving off and on without having to fully delete the stack, which has side effects like deleting the S3 bucket and requiring reentry of all parameters on recreation.

If this parameter is false (to turn off serving), we only keep around
static entities - e.g. roles, instance functions, and the S3 bucket for
image uploads. This allows us to more easily flip serving off and on
without having to fully delete the stack, which has side effects like
deleting the S3 bucket and requiring reentry of all parameters on
recreation.
Copy link
Member

@ebroder ebroder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@ebroder ebroder merged commit fa40156 into deathandmayhem:main Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants